[FreeBSD] suspend all other threads before closing file descriptors #8251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-yuji
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
dschaefer2,
francescomikulis,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci please test |
jakepetroules
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suspend all other threads first before closing file descriptors and exec.
Motivation:
See #8197 #8180,
swift runcan crash due to race condition between libdispatch controlled threads. To properly mitigate this, suspend all other threads (including those managed by libdispatch) before closing the file descriptors.Modifications:
Call
pthread_suspend_all_npbefore closing file descriptors, this api is not portable but exists on both FreeBSD and OpenBSD. However, since the Glibc overlay for OpenBSD does not include <pthread_np.h>, we guard this and make it available for FreeBSD only.